Skip to content

fix: add tooltips to input icons #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2024
Merged

fix: add tooltips to input icons #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions src/components/input/baseInput/baseInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,16 +201,18 @@ function BaseInputElement(
</Box>
<Box className="rustic-input-actions">
{props.children}
<IconButton
data-cy="send-button"
aria-label="send message"
onClick={handleSendMessage}
disabled={isSendDisabled}
color="primary"
className="rustic-send-button"
>
<Icon name="send" />
</IconButton>
<Tooltip title="Send">
<IconButton
data-cy="send-button"
aria-label="send message"
onClick={handleSendMessage}
disabled={isSendDisabled}
color="primary"
className="rustic-send-button"
>
<Icon name="send" />
</IconButton>
</Tooltip>
</Box>
</Box>
)
Expand Down
33 changes: 21 additions & 12 deletions src/components/input/multimodal/uploader/uploader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import Box from '@mui/material/Box'
import Card from '@mui/material/Card'
import IconButton from '@mui/material/IconButton'
import LinearProgress from '@mui/material/LinearProgress'
import Tooltip from '@mui/material/Tooltip'
import Typography from '@mui/material/Typography'
import type { AxiosProgressEvent } from 'axios'
import axios from 'axios'
Expand Down Expand Up @@ -231,15 +232,17 @@ function Uploader(props: UploaderProps) {
className="rustic-upload-progress"
/>
)}
<IconButton
data-cy="delete-button"
color="primary"
onClick={() => handleDelete(file, index)}
className="rustic-delete-button"
aria-label="cancel file upload"
>
<span className="material-symbols-rounded">cancel</span>
</IconButton>
<Tooltip title="Delete">
<IconButton
data-cy="delete-button"
color="primary"
onClick={() => handleDelete(file, index)}
className="rustic-delete-button"
aria-label="cancel file upload"
>
<span className="material-symbols-rounded">cancel</span>
</IconButton>
</Tooltip>
</Box>
</Card>
)
Expand Down Expand Up @@ -282,9 +285,15 @@ function Uploader(props: UploaderProps) {
<>
<Box className="rustic-uploader">
<label htmlFor={inputId} data-cy="upload-button">
<IconButton component="span" aria-label="Upload file" color="primary">
<span className="material-symbols-rounded">upload_2</span>
</IconButton>
<Tooltip title="Upload">
<IconButton
component="span"
aria-label="Upload file"
color="primary"
>
<span className="material-symbols-rounded">upload_2</span>
</IconButton>
</Tooltip>
</label>
<input
type="file"
Expand Down