Skip to content

gencat: Fix clippy::needless_range_loop #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2024
Merged

gencat: Fix clippy::needless_range_loop #320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion i18n/gencat.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,6 +553,7 @@ impl MessageCatalog {
}

/// Read the **GNU based** binary catalog file and build [MessageCatalog]
#[allow(clippy::needless_range_loop)]
pub fn read_catfile<T: Read>(
mut input: T,
) -> Result<MessageCatalog, Box<dyn std::error::Error>> {
Expand Down Expand Up @@ -590,7 +591,7 @@ impl MessageCatalog {
ptr += 4;
}

// note: probably compare be_array and le_array as they should be the same
// TODO: probably compare be_array and le_array as they should be the same

let string_pool = &buf[ptr..];

Expand Down