Skip to content

Conversation

fox0
Copy link
Contributor

@fox0 fox0 commented Sep 25, 2024

No description provided.

@jgarzik jgarzik merged commit 6917075 into rustcoreutils:main Sep 25, 2024
2 checks passed
@jgarzik
Copy link
Contributor

jgarzik commented Sep 25, 2024

Merged.

As general advice on cleanups: For larger cleanups, it is preferred to paste a script that generates the cleanups into the PR, or simply file an issue + cleanup script.

A cleanup script is better for security reviews, ensuring that the cleanup script generates 100% match with PR's source code changes.

For small cleanups and just a few files, a script is not necessary. A cleanups start to touch dozens or hundreds of files, a script will be a requirement. It is a range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants