Skip to content

Add fmt check in CI #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Add fmt check in CI #251

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
284a8aa
Add fmt check in CI
fox0 Sep 24, 2024
6bc1478
CI: Delete the commented
fox0 Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions .github/workflows/TestingCI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,21 @@ env:

jobs:
linux-ubuntu:

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- name: Fetch
run: cargo fetch
- name: Build
run: cargo build --release --verbose
- name: Run tests
run: cargo test --release --verbose
- uses: actions/checkout@v4
- name: Fetch
run: cargo fetch
- name: Build
run: cargo build --release --verbose
- name: Run tests
run: cargo test --release --verbose
- name: Run fmt check
run: cargo fmt --all -- --check
# - name: Run clippy check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. A PR should "do what it says, and no more"

  2. Never add commented-out code or instructions. Any code not run is code never tested, and will become fragile and break.

  3. Delete the commented out part of this PR, and it is ok.

# run: cargo clippy --all-features -- -D warnings

macos-homebrew:

runs-on: macos-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -46,4 +47,3 @@ jobs:
run: cargo build --release --verbose
- name: Run tests
run: cargo test --release --verbose