awk: fix escaped backslash and final escaped double qoute handling in strings #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An escaped double quote is recognized by the grammar, but when
it's the last character in the string, trim_matches() would
strip it along with the final delimiter, leaving a bare backslash
at the end and resulting in an invalid escape sequence.
The fix uses strip_{prefix,suffix}() to remove the quotes, relying
on the grammar to deliver a correctly delimited string.
|
Superceded by #222 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two commits in this PR fix a) recognizing an escaped backslash as valid in a string, b) overeager stripping of double quotes from a grammar-recognized string, which would result in a final escaped double quote to be removed, resulting in an invalid escape sequence.
Fixes #217