Skip to content

Add OffscreenCanvas support #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2023
Merged

Add OffscreenCanvas support #103

merged 1 commit into from
Jun 4, 2023

Conversation

daxpedda
Copy link
Member

@daxpedda daxpedda commented May 8, 2023 •
edited
Loading

This is blocked on wasm-bindgen/wasm-bindgen#3319 wasm-bindgen/wasm-bindgen#3416. Waiting for a new web-sys release.

Based on #76 (merged).

@daxpedda daxpedda mentioned this pull request May 8, 2023
Merged
@daxpedda daxpedda force-pushed the web-offscreen-canvas branch 2 times, most recently from 27f10de to 141ab01 Compare May 8, 2023 13:45
@daxpedda daxpedda marked this pull request as ready for review May 9, 2023 23:18
@daxpedda daxpedda requested a review from john01dav as a code owner May 9, 2023 23:18
@daxpedda daxpedda requested review from notgull and removed request for john01dav May 9, 2023 23:18
daxpedda
daxpedda commented May 9, 2023
View reviewed changes
notgull
notgull requested changes May 9, 2023
View reviewed changes
@daxpedda daxpedda marked this pull request as draft May 9, 2023 23:39
@daxpedda daxpedda force-pushed the web-offscreen-canvas branch from ed748aa to e0b8f65 Compare May 9, 2023 23:45
@daxpedda daxpedda mentioned this pull request May 14, 2023
Merged
@daxpedda daxpedda marked this pull request as ready for review May 16, 2023 20:46
@daxpedda daxpedda requested a review from notgull May 16, 2023 20:46
notgull
notgull requested changes May 16, 2023
View reviewed changes
@daxpedda daxpedda requested a review from notgull May 17, 2023 10:35
@daxpedda
Copy link
Member Author

Let's merge it after #104, rebasing #103 is easier.

@daxpedda daxpedda force-pushed the web-offscreen-canvas branch 2 times, most recently from 3e4aff5 to 1050c10 Compare June 4, 2023 23:16
@daxpedda daxpedda requested a review from notgull June 4, 2023 23:17
notgull
notgull approved these changes Jun 4, 2023
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@daxpedda daxpedda force-pushed the web-offscreen-canvas branch from 1050c10 to 42dea8a Compare June 4, 2023 23:22
@daxpedda daxpedda merged commit 6c78268 into rust-windowing:master Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@notgull notgull notgull approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@daxpedda @notgull