-
Notifications
You must be signed in to change notification settings - Fork 83
Upgrade to 2021 edition #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What's the benefits of this upgrading? |
097c4fc
to
17ad9d4
Compare
I think it's better to use latest stable version of rust |
https://doc.rust-lang.org/edition-guide/editions/index.html#editions-do-not-split-the-ecosystem
Does this mean that other crates that depend on this crate will not fail to compile due to the editions issue? |
So it looks like we can update it. I think this PR fell into the crack, let's try to start again ;-) @obeis can you rebase on current main? |
Signed-off-by: Obei Sideg <[email protected]>
@stefano-garzarella Done |
Signed-off-by: Obei Sideg [email protected]
Summary of the PR
Upgrade to 2021 edition
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s
), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
unsafe
code is properly documented.