Skip to content

Conversation

obeis
Copy link
Contributor

@obeis obeis commented Aug 26, 2022

Signed-off-by: Obei Sideg [email protected]

Summary of the PR

Upgrade to 2021 edition

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR are signed (with git commit -s), and the commit
    message has max 60 characters for the summary and max 75 characters for each
    description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • Any newly added unsafe code is properly documented.

sboeuf
sboeuf previously approved these changes Aug 29, 2022
@jiangliu
Copy link
Member

What's the benefits of this upgrading?

@obeis obeis force-pushed the upgrade-to-2021 branch 2 times, most recently from 097c4fc to 17ad9d4 Compare August 29, 2022 11:12
@obeis obeis requested review from sboeuf and removed request for eryugey, jiangliu, slp and stefano-garzarella August 29, 2022 11:16
@obeis
Copy link
Contributor Author

obeis commented Aug 29, 2022

I think it's better to use latest stable version of rust

@wllenyj
Copy link
Contributor

wllenyj commented Aug 29, 2022

https://doc.rust-lang.org/edition-guide/editions/index.html#editions-do-not-split-the-ecosystem

The most important rule for editions is that crates in one edition can interoperate seamlessly with crates compiled in
other editions. This ensures that the decision to migrate to a newer edition is a "private one" that the crate can make
without affecting others.

Does this mean that other crates that depend on this crate will not fail to compile due to the editions issue?

@wllenyj wllenyj mentioned this pull request Sep 6, 2022
3 tasks
@stefano-garzarella
Copy link
Member

https://doc.rust-lang.org/edition-guide/editions/index.html#editions-do-not-split-the-ecosystem

The most important rule for editions is that crates in one edition can interoperate seamlessly with crates compiled in
other editions. This ensures that the decision to migrate to a newer edition is a "private one" that the crate can make
without affecting others.

Does this mean that other crates that depend on this crate will not fail to compile due to the editions issue?

So it looks like we can update it.

I think this PR fell into the crack, let's try to start again ;-)

@obeis can you rebase on current main?

Signed-off-by: Obei Sideg <[email protected]>
@obeis
Copy link
Contributor Author

obeis commented Oct 1, 2023

@stefano-garzarella Done

@stefano-garzarella stefano-garzarella merged commit 87b0cbf into rust-vmm:main Oct 2, 2023
@obeis obeis deleted the upgrade-to-2021 branch October 2, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants