Remove SmallRng::from_thread_rng #1532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
approved these changes
Nov 20, 2024
| /// ``` | ||
| /// # use rand::{SeedableRng, rngs::SmallRng}; | ||
| /// let rng = SmallRng::from_os_rng(); | ||
| /// let rng = SmallRng::seed_from_u64(1); |
Member
There was a problem hiding this comment.
I think we can keep the mention of from_os_rng.
| g.throughput(criterion::Throughput::Bytes(size_of::<T>() as u64)); | ||
| g.bench_function(name, |b| { | ||
| let mut rng = Pcg64Mcg::from_os_rng(); | ||
| let mut rng = Pcg64Mcg::from_rng(&mut rand::rng()); |
Member
There was a problem hiding this comment.
Use of from_os_rng should not influence the benchmark results since only time for the closure passed to iter is measured.
Member
Author
There was a problem hiding this comment.
Agreed. It may improve set-up time slightly; at any rate I see no harm in using rand::rng().
benjamin-lieser
pushed a commit
to benjamin-lieser/rand
that referenced
this pull request
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentrySummary
Title
Motivation
See #1531