rand_distr: split gamma module #1464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelOwenDyer
requested changes
Jul 10, 2024
There was a problem hiding this comment.
I agree with this change, I think one module per distribution is easier to keep a clear view over than when they are grouped together. I have a few thoughts/suggestions:
- Nearly all distributions define a type called
Errorwhich then gets re-exported with the name of the distribution prepended on, but these new modules define the error type name already with the distribution name in them. I would suggest staying consistent here. - Might want to give the same treatment to
ZetaandZipf StudentTmight deserve its own error type (alias), but this is definitely less important
MichaelOwenDyer
approved these changes
Jul 11, 2024
benjamin-lieser
pushed a commit
to benjamin-lieser/rand
that referenced
this pull request
Feb 5, 2025
Move Beta, Student's t, Fisher-F, Chi-squared and Zeta distributions to their own modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move Beta, Student's t, Fisher-F and Chi-squared distributions to their own modules.
All recently added distributions (including the very minimal circle/disc/ball/sphere distributions) use their own module, and I find this makes PR reviews easier.