Put macro x86_intrinsic_impl behind x86 configuration
#1431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheIronBorn
approved these changes
Apr 3, 2024
|
I'm gonna go ahead and merge this @dhardy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The macro
x86_intrinsic_implinsrc/distributions/integer.rsis only ever used inside this configuration:#[cfg(any(target_arch = "x86", target_arch = "x86_64"))]but the macro itself is declared without that configuration. I just added it, and removed a file-level import which was only used inside the macro.Motivation
This should resolve the unused code warnings currently occurring on master.
Details
See changes