Fix various CI failures #844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are issues with the May 2023 releases, pin to a known-working version.
nicholasbishop
changed the title
nicholasbishop
force-pushed
the
bishop-pin-qemu
branch
from
16d18f9 to
3ee53a5
Compare
nicholasbishop
changed the title
phip1611
approved these changes
Jun 4, 2023
nicholasbishop
added a commit
that referenced
this pull request
Jan 21, 2025
…) signature"
The signature fix itself is trivial, just adding a `&`. The test changes had
already been partially rewritten during the freestanding table function
refactor. Now alter constants and variable names, remove a use of `as`, and free
the memory at the end.
The PR originally included a cleanup commit ("uefi-test-runner: Fix buffer
alignment on ia32") that ended up being cherry-picked and merged in a separate
PR: #844. Rewrite that fix here as
well.
This covers these commits:
d7697c3
9609873
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cherry-picked in two fixes from #843 as well.
Checklist