Merge release-v0.30 branch into main #1289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The missing lifetime means that the &[u8] buffer could be freed while the &DevicePath still exists, which is UB. (cherry picked from commit a9e48c2)
This release contains a cherry-pick of rust-osdev#1282.
…-030 release: uefi-0.30.0
Update transitive libs.
|
Generally, I think the approach you have taken is valid. But I think, we should merge the changes into main as well. It feels more consistent and streamlined, doesn't it? @nicholasbishop |
|
Yep, I didn't think about the main branch but this definitely makes sense. |
nicholasbishop
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is weird that we have a release v0.30 branch and a released version, but
uefiis stillat
0.29on the main branch. This merges the branch from #1285 into main with some necessary adaptions.Checklist