uefi: Fix lifetimes in device_path TryFrom<&[u8]> impls #1282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The missing lifetime means that the &[u8] buffer could be freed while the &DevicePath still exists, which is UB.
nicholasbishop
force-pushed
the
bishop-fix-dp-lifetimes
branch
from
de79cd7 to
a9e48c2
Compare
|
Shouldn't miri catch this? Ah, I guess there are no unit tests for this functionality? |
|
There are some tests. But since miri is a runtime checker, not a static analyzer, it would only catch it if you modified the test to drop the source buffer early. (And we don't want to modify the tests to do that, because then the code wouldn't compile with the fix.) |
nicholasbishop
added a commit
to nicholasbishop/uefi-rs
that referenced
this pull request
Aug 2, 2024
This release contains a cherry-pick of rust-osdev#1282.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The missing lifetime means that the &[u8] buffer could be freed while the &DevicePath still exists, which is UB.
Bug: #1281
Checklist