boot: Always impl Drop for MemoryMapBackingMemory #1248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gating this on `cfg(not(test))` isn't necessary; during unit tests `system_table_boot()` will return `None` and so the drop won't do anything anyway. Also fix a typo, excited -> exited.
phip1611
reviewed
Jul 21, 2024
| @@ -1747,7 +1745,7 @@ impl Drop for MemoryMapBackingMemory { | |||
| log::error!("Failed to deallocate memory map: {e:?}"); | |||
| } | |||
| } else { | |||
| log::debug!("Boot services are excited. Memory map won't be freed using the UEFI boot services allocator."); | |||
phip1611
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gating this on
cfg(not(test))isn't necessary; during unit testssystem_table_boot()will returnNoneand so the drop won't do anything anyway.Also fix a typo, excited -> exited.
Checklist