Skip to content

Nuke uefi services from repository #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

phip1611
Copy link
Member

@phip1611 phip1611 commented Apr 19, 2024

Follow-up for #1140 and closes #1129.

Steps to undraft and Open Questions

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@phip1611 phip1611 marked this pull request as draft April 19, 2024 14:58
@phip1611 phip1611 force-pushed the nuke-uefi-services branch from 75ebec0 to b67db56 Compare April 19, 2024 16:32
@phip1611 phip1611 marked this pull request as ready for review April 19, 2024 16:32
@phip1611 phip1611 requested a review from nicholasbishop April 19, 2024 16:33
@phip1611
Copy link
Member Author

The code with the future permutations is originally from you, @nicholasbishop. Any idea on how to continue here? :)

@phip1611 phip1611 changed the title Nuke uefi services Nuke uefi services from repository Apr 19, 2024
@nicholasbishop
Copy link
Member

I think the updates you made to build_feature_permutations look correct, just need to also update Feature::package_features to add PanicHandler and Qemu to the Uefi list. Also can drop ServicesLogger, since that's just Logger now.

@phip1611 phip1611 force-pushed the nuke-uefi-services branch from 62df656 to 49a4411 Compare April 20, 2024 13:21
@phip1611
Copy link
Member Author

Thanks, fixed.

@phip1611 phip1611 force-pushed the nuke-uefi-services branch from 49a4411 to 4cea282 Compare April 20, 2024 13:25
@nicholasbishop nicholasbishop added this pull request to the merge queue Apr 20, 2024
Merged via the queue into rust-osdev:main with commit a307922 Apr 20, 2024
12 checks passed
@phip1611 phip1611 deleted the nuke-uefi-services branch June 23, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuke "uefi-services" from repository
2 participants