Skip to content

Add a File::get_boxed_info_in using allocator_api #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benpye opened this issue Aug 20, 2022 · 5 comments · Fixed by #584
Closed

Add a File::get_boxed_info_in using allocator_api #483

benpye opened this issue Aug 20, 2022 · 5 comments · Fixed by #584
Assignees

Comments

@benpye
Copy link

benpye commented Aug 20, 2022

It would be nice if we had a version of get_boxed_info that did not rely on the global allocator for use with the experimental feature allocator_api. I think there is sufficient support to return a boxed value with a specific allocator, specifically Box::from_raw_in.

I ended up writing this to use myself - I think it should look something like https://gist.github.com/benpye/b46a5d2ea1a0a59e037ae3522731d0e4

@phip1611
Copy link
Member

phip1611 commented Nov 20, 2022

@nicholasbishop I think we can solve this easily once #559 is merged. I assigned the issue to me.

@phip1611
Copy link
Member

Btw, as we do not have a internal discussion platform, I do it here: @nicholasbishop did you notice that I've pinged you on https://gitter.im/rust-osdev/Lobby? It'd be great if you can help

@nicholasbishop @GabrielMajeri
Would it make sense to have a dedicated communication channel (signal, Telegram) or are discussions on github sufficient?

@GabrielMajeri
Copy link
Collaborator

@nicholasbishop @GabrielMajeri Would it make sense to have a dedicated communication channel (signal, Telegram) or are discussions on github sufficient?

Sorry, I haven't been able to catch up and help with uefi-rs lately because of schoolwork and some personal projects. We can use other communication channels, sure, but I'd be just as unresponsive there as I'm currently on GitHub 😅 so I don't necessarily see the point.

@nicholasbishop
Copy link
Member

nicholasbishop commented Nov 25, 2022

Thanks for the heads up, I didn't see that discussion on gitter.

Re a different communication channel, what about enabling Github Discussions on the repo? It's kinda similar to issues, but can encourage broader discussion than issues which tend to just get used for bug reports.

I prefer that over chats like gitter/discord/zulip, especially because it's searchable (gets indexed by Google etc) and makes it easier to respond when one has time as opposed to a live chat.

@phip1611
Copy link
Member

phip1611 commented Nov 25, 2022

Actually, I just wasn't sure where totally unrelated things like "please look on gitter.im" and similar messages should be. I also assume such messages are very rare. Yeah, maybe the github discussions feature is what we need and a chat group overkill + has other disadvantages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants