Export the #[derive(FromPrimitive)] from rust proper #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the name to
#[derive(NumFromPrimitive)]
in order to not conflict with the libsyntax macro.If the general direction of this num library will supplant
std::num
, then I'd instead prefer to do the same trick we did for rustc-serialize, and have the compiler add a#[derive(RustcFromPrimitive)]
that uses the trait in this crate instead.