Implement Pow by value
#137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already had `Pow` for references, so the default call doesn't consume your allocation, but this wasn't sufficient for uses like `BigRational`. Now we do implement it by value, and have also added a new inherent method `pow(&self, exp: u32)` that takes precedence. That exponent type matches the same method on primitive integers, and is likely sufficient for most use cases. Fixes rust-num#106
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already had
Powfor references, so the default call doesn't consumeyour allocation, but this wasn't sufficient for uses like
BigRational.Now we do implement it by value, and have also added a new inherent
method
pow(&self, exp: u32)that takes precedence. That exponent typematches the same method on primitive integers, and is likely sufficient
for most use cases.
Fixes #106