Skip to content

fix parsing error on empty IFLA_AF_SPEC #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2025
Merged

fix parsing error on empty IFLA_AF_SPEC #138

merged 3 commits into from
May 5, 2025

Conversation

bebecue
Copy link
Contributor

@bebecue bebecue commented Oct 4, 2024

No description provided.

cathay4t
cathay4t requested changes Jan 20, 2025
View reviewed changes
Copy link
Member

@cathay4t cathay4t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you include a unit test case with captured netlink message for this?

@cathay4t cathay4t added the Wait_Submitter PR reviewed with change requests label Jan 20, 2025
@bebecue
Copy link
Contributor Author

bebecue commented Jan 21, 2025

Yes, I added one in d80436b

@bebecue bebecue requested a review from cathay4t January 21, 2025 09:12
cathay4t
cathay4t approved these changes May 5, 2025
View reviewed changes
Copy link
Member

@cathay4t cathay4t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@cathay4t cathay4t force-pushed the fix-IFLA_AF_SPEC branch from 265988a to 58cc296 Compare May 5, 2025 02:27
@cathay4t cathay4t enabled auto-merge (rebase) May 5, 2025 02:27
@cathay4t cathay4t merged commit 69c4e01 into rust-netlink:main May 5, 2025
8 checks passed
@ejcaruso ejcaruso mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cathay4t cathay4t cathay4t approved these changes

Assignees
No one assigned
Labels
Wait_Submitter PR reviewed with change requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bebecue @cathay4t