Strongly typed Axis argument (newtype called Axis) #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #96 for an alternative approach, and explanation why the generic version will not be used. cc @vbarrielle Do you think this is ok? It's clearly more to type, but it's not possible to confuse the axis and index arguments anymore. |
bluss
force-pushed
the
strongly-typed-axis
branch
from
edda2f0 to
9bd49a8
Compare
|
Yes I think this is nice. It really removes some possible bugs and it's not that much to type. I also feel it makes the code more readable. I agree with you that the approach in #96 is a bit too much generics. |
bluss
added a commit
that referenced
this pull request
Feb 29, 2016
Strongly typed Axis argument (newtype called Axis)
This was referenced Feb 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a newtype
Axis(usize)for all method arguments that need an axis.