Skip to content

Conversation

jturner314
Copy link
Member

The scalar_prod method hasn't been released yet, so we can freely rename it. The old scalar_sum method now has a deprecated annotation, which causes a warning when building code that uses it and is visible in the docs.

See also this comment from @bluss.

@jturner314 jturner314 changed the title Rename scalar_prod and scalar_sum to prod and sum Rename scalar_prod and scalar_sum to product and sum Oct 27, 2018
@jturner314
Copy link
Member Author

I think that product is a better name than prod, because it's clear what it means and the Iterator trait in the standard library uses the name product.

@bluss
Copy link
Member

bluss commented Oct 28, 2018

product is good. Good to avoid scalar_prod, that's just a confusion point vs the dot product. 🙂

@jturner314 jturner314 merged commit ae13fd2 into rust-ndarray:master Nov 7, 2018
@jturner314 jturner314 deleted the rename-scalar-ops branch November 7, 2018 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants