Add link anchor to team and subteam headings #1641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can approve this once you fix the hover style; probably just give it a class and add an |
pierwill
force-pushed
the
subteam-anchor
branch
from
a2ee922 to
22ddc3d
Compare
Manishearth
reviewed
Feb 15, 2022
src/styles/app.scss
Outdated
| @@ -382,6 +382,10 @@ footer { | |||
| } | |||
| } | |||
|
|
|||
| a.sub { | |||
There was a problem hiding this comment.
nit: please use a more descriptive class name, probably linkable-subheading
pierwill
force-pushed
the
subteam-anchor
branch
from
22ddc3d to
c7997fb
Compare
Manishearth
approved these changes
Feb 15, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to close #1638 (and maybe #900, too).