Skip to content

Partial revert change and improve responsive layout #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Partial revert change and improve responsive layout #1188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions templates/community/index.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,29 @@
</ul>
</div>
</div>
<div class="dn db-l">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original code prior to 11 days ago had .dn-m on line 86 the problem is that that the flex class overrides that .dn-m for specificity reasons. So it needs to sit higher in its own container.

So the rule on line 85 now says display: none and display:block on large screen.

<div class="flex flex-column flex-row-l">
<div class="w-33-l mh3-l pt0 flex flex-column justify-start" id="users-forum">
<a href="https://users.rust-lang.org" class="button button-secondary">{{fluent "community-discourse-button"}}</a>
</div>

<div class="w-33-l mh3-l pt4 pt0-l flex flex-column justify-start" id="internals-forum">
<a href="https://internals.rust-lang.org" class="button button-secondary">{{fluent "community-discourse-button"}}</a>
</div>

<div class="w-33-l mh3-l pt4 pt0-l flex flex-column justify-start" id="chat-platforms">
{{!-- TODO: remove padding and margin once global declarations are gone --}}
<ul class="list pa0 ma0">
<li class="mb3">
<a href="https://discord.gg/rust-lang" class="button button-secondary">{{fluent "discord"}}</a>
</li>
<li class="mb3">
<a href="{{baseurl}}/governance" class="button button-secondary">{{fluent "community-teams-learn"}}</a>
</li>
</ul>
</div>
</div>
</div>
</div>
</section>

Expand Down