Partial revert change and improve responsive layout #1188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fasani
commented
Jul 12, 2020
| @@ -82,6 +82,29 @@ | |||
| </ul> | |||
| </div> | |||
| </div> | |||
| <div class="dn db-l"> | |||
There was a problem hiding this comment.
The original code prior to 11 days ago had .dn-m on line 86 the problem is that that the flex class overrides that .dn-m for specificity reasons. So it needs to sit higher in its own container.
So the rule on line 85 now says display: none and display:block on large screen.
Closed
|
Thank you for your PR! |
XAMPPRocky
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@XAMPPRocky Hey, I noticed my earlier commit (11 days ago) had side effects on larger screens, buttons were no longer visible, I have reverted it and wrapped the buttons in an additional div/class (see additional comment).
Demo:
https://www.loom.com/share/cf6966b43e844258b04459df22ff5b81