Make .highlight smaller to avoid splitting text #1136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The headlines on the website are unnecessarily difficult to read due to the text being split in half by two different backgrounds with a hard border. This makes the highlight a little smaller and a little lower so it looks more like a thick underline.
|
Thank you for your PR! Generally I'm in favour of this change, though I'll need to check if there's any places where this change breaks the existing design. If no one else has concerns and once I've done a cursory review of the impact of this change I'll merge this in (Which I'll get to probably sometime next week). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The headlines on the website are unnecessarily difficult to read due to the text being split in half by two different backgrounds with a hard border. This PR makes the highlight a little smaller and a little lower so it looks more like a thick underline. I find that this greatly helps the readability of the headlines.
Before:
After:
