Skip to content

Make .highlight smaller to avoid splitting text #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

mjbshaw
Copy link
Contributor

@mjbshaw mjbshaw commented Jun 4, 2020

The headlines on the website are unnecessarily difficult to read due to the text being split in half by two different backgrounds with a hard border. This PR makes the highlight a little smaller and a little lower so it looks more like a thick underline. I find that this greatly helps the readability of the headlines.

Before:
before

After:
after

The headlines on the website are unnecessarily difficult to read due to the text being split in half by two different backgrounds with a hard border. This makes the highlight a little smaller and a little lower so it looks more like a thick underline.
@XAMPPRocky
Copy link
Member

Thank you for your PR! Generally I'm in favour of this change, though I'll need to check if there's any places where this change breaks the existing design. If no one else has concerns and once I've done a cursory review of the impact of this change I'll merge this in (Which I'll get to probably sometime next week).

@XAMPPRocky XAMPPRocky merged commit aa0085b into rust-lang:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants