Main rust repo has "A-macros-2.0" label, rustbot cannot parse this

[safinaskar]

Main rust repo has "A-macros-2.0" label, rustbot cannot parse this.

I just wrote this comment: rust-lang/rust#41430 (comment) . Command rustbot label: -A-macros-2.0 didn't work. I suspect this is because rustbot's parser doesn't allow dots in label names. So, please, fix rustbot.

(There are other solutions, through. One of them is to forbid labels with dots in main rust repo. Another is to give me right to directly set labels. :) )

(Ha-ha, even this repo itself has bad labels, such as "help wanted", which probably will not be parsed by rustbot, too.)

Also, it seems #1633 will fix this bug.

@rustbot label: +A-command-parsing +A-labeling +bug

[rustbot]

Error: Label A-command-parsing can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

[safinaskar]

@rustbot label: +A-labeling
@rustbot label: +bug

[rustbot]

Error: Label A-labeling can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

[apiraino]

happy to have a look at this

@rustbot claim

[apiraino]

@safinaskar so, we investigated a little bit here.

As you point out, labels with dots are not parsed by the bot, by design (we sanitize the input and remove puncuation).
The fact that the user does not get a feedback is bad UI. We're not sure, though, how we can improve this since:

• changing a label we've been using since 2017 could make some people unhappy
• we do not want to add a comment suggesting what to do because the thread can get noisy
• we do not want to edit and fixing the user's comment because it has side-effects, at least until we have a better story

So, hm ... leaving this open for now 🤷‍♂

[safinaskar]

@apiraino , so is there a way I can add or remove "A-macros-2.0" labels from issues?

[apiraino]

No, not at this time, sorry. In case ask for help, I think you catched the only case in +800 labels. If we don't come up with a better solution we might choose one of the above (I'd vote for renaming the label after a cursory check at least on our tooling).

[safinaskar]

@apiraino , I will repeat: #1633 seems to fix this issue. It allows one to add labels with spaces, and, presumably, with dots, as you can see in example

[apiraino]

@apiraino , I will repeat: #1633 seems to fix this issue. It allows one to add labels with spaces, and, presumably, with dots, as you can see in example

Please read my comment about using Github label rendering (maybe it's nested in the thread and not easily found)

[Noratrieb]

changing a label we've been using since 2017 could make some people unhappy

I don't think anyone will be upset if we rename the label to A-macros-2-0 but also just allowing periods in labels seems fine too. if you don't want to do that though I can just rename the label

[apiraino]

I can also rename the label, I just want to be sure we're not breaking (or not overlooking) anything. So I asked on Zulip

[apiraino]

After about 2 days since asking, nobody opposed to renaming this label, so I think I'll proceed.

Thanks @safinaskar for pointing it out to us (I wasn't aware of this quirk!)