non-defining uses with non-param args will be break

[lcnr]

https://rust.godbolt.org/z/Yoc1efvxc

trait Recur {
    fn recur(self);
}

impl<T> Recur for () {
    fn recur(self) {}
}

fn recurse_no_define<T>(b: bool) -> impl Recur {
    if b {
        recurse_no_define::<()>(false).recur();
    }
}

This currently compiles, but even just tryin got normalize the RPIT of the recursive call will fail as it does not have fully generic args.

Normalization fails and we don't treat the opaque as rigid

[lcnr]

sus idea:

The reason we don't support defining opaques with unique params as args as that otherwise the mapping from the opaque to the hidden type is unclear: e.g. RPIT<u8> = u8 could either define RPIT<T> = T or RPIT<T> = u8.

This is only an issue if there is no proper defining use. If we had one defining use RPIT<T> = T and another one using RPIT<u8> = u8, we could use the fully general one to define the hidden type, and then only check that the hidden type of the non-general one by instantiating that hidden type with u8 in this case and equating them

[lcnr]

The same approach would also allow non-defining uses of an opaque as long as there is one use which fully defines. E.g.

If we use define Opaque<T, U> = T and Opaque<U, T> = ?x this currently errors, but we could take the Opaque<T, U> = T definition, map the hidden type to the context of the opaque, and then instantiate it with U and T, constraining ?x . This does not seem very desirable, but may be necessary to avoid breaking changes because the new solver tries to normalize opaques currently treated as rigid

[compiler-errors]

This also doesn't work as soon as the opaque has lifetimes since we need region info to correlate the regions of the defining use w the hidden type.

[lcnr]

relied on by wax-0.6.0 https://crater-reports.s3.amazonaws.com/pr-133502-6/try%233142be4586e10dc773ebcd0218cc336b7e474fac/reg/wax-0.6.0/log.txt