Add ADX-related intrinsics #631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnzlbg
reviewed
Jan 4, 2019
gnzlbg
reviewed
Jan 4, 2019
alexcrichton
force-pushed
the
adx
branch
2 times, most recently
from
aa0b548 to
d865c17
Compare
jethrogb
reviewed
Jan 31, 2019
| /// the carry-out is returned (carry or overflow flag). | ||
| #[inline] | ||
| #[target_feature(enable = "adx")] | ||
| #[cfg_attr(test, assert_instr(adc))] |
There was a problem hiding this comment.
I don't think this is correct, it should say adcx
There was a problem hiding this comment.
@jethrogb Could you submit a PR with that fix?
There was a problem hiding this comment.
I think some work is involved in actually making it work that way, see #663
There was a problem hiding this comment.
I've opened an issue so that we don't forget about this #666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #322