Add some SSE _mm_cvt* instructions #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The *_pi variants are currently blocked by rust-lang#74
The _mm_cvtpi*_ps intrinsics are blocked by rust-lang#74
|
Thanks! It looks like the tests are failing, but I think you can just remove the instruction suffix and they should pass? |
|
Yeah, this might need some tinkering. On OSX it does actually use different instruction suffixes. The 32 bit failure might be a bit more complicated. I'll let you know when it's ready to merge. |
Also the si64 variants are only available on x86_64
|
@alexcrichton OK, actually wasn't that difficult. Apparently, some of these intrinsics are only available on x86_64. Ready to merge. |
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements:
_mm_cvtss_si32_mm_cvt_ss2si_mm_cvtss_si64_mm_cvttss_si32_mm_cvtt_ss2si_mm_cvttss_si64_mm_cvtsi32_ss_mm_cvt_si2ss_mm_cvtsi64_ss_mm_cvtss_f32Note that the following related instructions are currently blocked by #74
_mm_cvtps_pi32_mm_cvt_ps2pi_mm_cvttps_pi32_mm_cvtt_ps2pi_mm_cvtpi32_ps_mm_cvt_pi2ps