Do not emit undefined lshr/ashr for Neon shifts #1238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
In LLVM the lshr and ashr instruction is undefined when the amount is equal to the element size, but Neon shifts support such shifts. With signed values, when shifting by the element size is requested subtract one as right shifting a signed value by its size is equivalent to a shift of size - 1. When shifting an unsigned value by the element size, return a vector of all 0's as that's what the shift would result in.
JamieCunliffe
force-pushed
the
neon-shifts
branch
from
e738287 to
b391453
Compare
|
Should the constraint on the immediate be changed to exclude 64? Is 64 a valid argument for these immediates? |
|
64 is valid for these, https://developer.arm.com/architectures/instruction-sets/intrinsics/vshrd_n_s64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In LLVM the lshr and ashr instruction is undefined when the amount is
equal to the element size, but Neon shifts support such shifts.
With signed values, when shifting by the element size is requested
subtract one as right shifting a signed value by its size is
equivalent to a shift of size - 1.
When shifting an unsigned value by the element size, return a vector
of all 0's as that's what the shift would result in.