Skip to content

Conversation

hasenbanck
Copy link
Contributor

I took the vld1_* implementation as an example while writing the vst1_* implementation.

While the arm intrinsics use the LLVM provided intrinsics, I had to copy the approach taken by the SSE unaligned store intrinsics for the aarch64 implementation.

I also ported the SSE tests for the unaligned stores.

I'm not really sure about the #[cfg_attr(test, assert_instr(*))] asserts, since I couldn't find a away how to verify these tests. It would be great if somebody could hint me how to tests these.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

These operations need to be aligned by the element type alignment..
@Amanieu Amanieu merged commit 907cfb2 into rust-lang:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants