Format asm! macro calls #5191
Open
Format asm! macro calls #5191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytmimi
force-pushed
the
feature/format_asm_macro
branch
3 times, most recently
from
fbe8494 to
713ae48
Compare
ytmimi
force-pushed
the
feature/format_asm_macro
branch
from
713ae48 to
3f23b89
Compare
4 tasks
ytmimi
force-pushed
the
feature/format_asm_macro
branch
from
3f23b89 to
b3ae0ef
Compare
ytmimi
added
pr-merge-conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for formatting
asm!macro calls.Formatting for
asm!is gated behind a new unstableforamt_asm_macroconfiguration value.Tracking issue for the new configuration value can be found at #5210
The specific guidelines for formatting the macro are still being decided, but this PR goes a long way to formatting the various components of the
asm!macro (templates, operands, clobber_abis, and options).