Skip to content

fix not to break relative path link #4042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2020
Merged

fix not to break relative path link #4042

merged 1 commit into from
Feb 18, 2020

Conversation

rchaser53
Copy link
Contributor

fix: #4023

@rchaser53
Copy link
Contributor Author

rchaser53 commented Feb 9, 2020 •
edited
Loading

The rustc 1.43.0-nightly (07a34df 2020-02-08) cannot build rustc-ap-rustc data_structures-610.0.0.
So failed to CI. Need to update rustc-ap-* before handling this PR.
related: #4022 (comment)

@calebcartwright
Copy link
Member

Yup, #4022 will fix the issue for master and I've also opened #4043 to do the same for rustfmt 1.x

topecongiro
topecongiro approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@topecongiro topecongiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@topecongiro topecongiro merged commit 4464ab7 into rust-lang:master Feb 18, 2020
@rchaser53 rchaser53 deleted the issue-4023 branch February 18, 2020 12:56
@calebcartwright calebcartwright mentioned this pull request Apr 19, 2020
Closed
@ytmimi
Copy link
Contributor

ytmimi commented Apr 1, 2022

#5096 fixes the reference style link issue, however relative file paths in other contexts [link](./path/to/file) still get wrapped so I think this should be backported.

@ytmimi ytmimi mentioned this pull request Apr 1, 2022
Open
@ytmimi ytmimi added 1x-backport:pending Fixed/resolved in source but not yet backported to a 1x branch and release and removed backport-triage labels Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scampi scampi Awaiting requested review from scampi

1 more reviewer

@topecongiro topecongiro topecongiro approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
1x-backport:pending Fixed/resolved in source but not yet backported to a 1x branch and release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrap_comments breaks links with long URL
5 participants
@rchaser53 @calebcartwright @ytmimi @topecongiro @karyon