Fixes #1049 #1108
Closed
Fixes #1049 #1108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a regression test for this please? |
|
added! missed how to set configs on tests at first :) |
|
I fear an extra commit has sneaked into your branch |
|
whoops, fixed. thanks! |
| @@ -1,3 +1,4 @@ | |||
| // rustfmt-max_width: 100 | |||
There was a problem hiding this comment.
This shouldn't be necessary - it is the default
There was a problem hiding this comment.
i added it to be explicit, but will remove
|
Thanks for the added tests. The failing tests on the CI look spurious. |
|
@juicejitsu if it's alright, could you pull out the tests here that aren't in #1089 and we can land those. Sorry we didn't get to land your code here. |
|
sure np! i'll try another one :) note that the build will fail because it depends on the changes in #1089 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.