Fix off by 2 error in function sigs #1009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let max_space = context.config.max_width; | ||
| if used_space <= max_space { | ||
| (0, max_space - used_space, new_indent) | ||
| Some((0, max_space - used_space, new_indent)) | ||
| } else { | ||
| // Whoops! bankrupt. | ||
| // FIXME: take evasive action, perhaps kill the indent or something. |
There was a problem hiding this comment.
This FIXME can be removed now, right?
|
r+ with or without nit addressed |
Fixes #1000 This is a little conservative in some cases, but better than being wrong in others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1000
This is a little conservative in some cases, but better than being wrong in others.