Fix FIXME in Builder::and
and Builder::or
impls
#101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a bug in gccjit was resolved: https://gcc.gnu.org/bugzilla//show_bug.cgi?id=95498 the
Builder::and
andBuilder::or
impl can be fixed and made much cleaner.I think I did this right? Is there a list somewhere with the proper casting rules? I was a able to run
./test.sh
and it made it through testing rust tests:test result: FAILED. 4352 passed; 86 failed; 50 ignored; 0 measured; 0 filtered out; finished in 93.79s
closes #80