Add a benchmark for unicode_normalization #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This looks good to me. I'll wait for Travis to pass (it'll probably be a while as queue concurrency is currently still 3-5 for nursery due to migration to .com on Travis). |
This crate uses huge matches, showing performance issues in areas not yet covered by the existing benchmarks.
Contributor
Author
|
Oh, sorry, I had created the lock file, but missed that it was listed in the accompanying .gitignore. It's in the commit this time. |
Member
|
Will deploy later today! |
Contributor
|
Oh no, another benchmark with an underscore in its name... |
Contributor
Author
|
I didn't know that was a problem... 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crate uses huge matches, showing performance issues in areas not
yet covered by the existing benchmarks.