Skip to content

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Sep 25, 2025

I think that we have ~3 ways of testing the new job queue:

  1. Run both the old system and the job queue in parallel, but run the job queue collector in "dry run" mode, i.e. do not store anything in the DB
  2. Run both the old system and the job queue in parallel, but only use the job queue for try builds on a specific PR, and do not enqueue parent jobs, so that we only use the job queue for one PR and nothing else
  3. Stop the old system and test the job queue in production while it is stopped

This PR implements 2). While 1) would allow us to test more things, it would require non-trivial changes to the collector, and it would also fill the job queue and the benchmark requests table with a lot of data that we would then have to get rid of. So 2) seemed like the easiest option for now.

The commented code is temporary, of course.

My goal is to see what kind of interesting situations we run into when we merge this PR and start a few try builds on rust-lang/rust#147039. It should also help us figure out the things that we should be logging in the cron job.

@Kobzol Kobzol requested a review from Jamesbarford September 25, 2025 16:53
Copy link
Contributor

@Jamesbarford Jamesbarford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bar the test suite failing, this looks like a good idea to me 👍 . From my manual testing this should work.

@Kobzol Kobzol marked this pull request as ready for review October 2, 2025 07:12
@Kobzol Kobzol merged commit 6c1460f into rust-lang:master Oct 2, 2025
11 checks passed
@Kobzol Kobzol deleted the test-pr branch October 2, 2025 07:19
@Kobzol
Copy link
Member Author

Kobzol commented Oct 2, 2025

Let's see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants