Skip to content

Hide section chart for binary size metric #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Hide section chart for binary size metric #1774

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions site/frontend/src/pages/compare/compile/table/benchmark-detail.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,8 +407,8 @@ onMounted(() => {
<div ref="relativeChartElement"></div>
</div>
</div>
<div class="columns">
<div class="rows grow">
<div class="columns" v-if="props.metric !== BINARY_SIZE_METRIC">
<div class="rows center-items grow">
<div class="title bold">
Sections
<Tooltip
Expand All @@ -419,6 +419,10 @@ onMounted(() => {
based on wall-time.
</Tooltip>
</div>
<div style="font-size: 0.8em">
Note that the data for this chart is calculated from wall-time (it is
metric agnostic)!
</div>
<div>
<CompileSectionsChart
v-if="
Expand Down