Skip to content

Require perf-regression's to be -triaged to pass bors? #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mark-Simulacrum opened this issue Sep 15, 2021 · 2 comments
Open

Require perf-regression's to be -triaged to pass bors? #1007

Mark-Simulacrum opened this issue Sep 15, 2021 · 2 comments
Labels
A-procedure An issue related to performance tracking procedure

Comments

@Mark-Simulacrum
Copy link
Member

Following up on rust-lang/rust#88832, it seems like a reasonable step may be to restrict bors merges to only happen after any existing perf regressions have been justified.

This might have the negative side-effect of partially discouraging perf runs, but that is hopefully unlikely. Our lack of strong follow up with PR authors + reviewers on perf justification post merge does make it harder to push for it to happen; it may be that some broader T-compiler policy work is necessary here.

@rylev
Copy link
Member

rylev commented Sep 15, 2021

On the social side of things, I think we should push in #t-compiler meetings for reviewers to run perf runs more often. I think the following mantra applies: "when in doubt whether this could cause a perf regression, do a perf run"

@Mark-Simulacrum
Copy link
Member Author

I think we've done good work there. We just need to push on the follow up to perf runs. Part of that is likely providing better tooling for diagnosing regressions -- currently it's a bit of an opaque step if the perf.r-l.o UI doesn't show you anything.

@rylev rylev added the A-procedure An issue related to performance tracking procedure label Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-procedure An issue related to performance tracking procedure
Projects
None yet
Development

No branches or pull requests

2 participants