Skip to content

Change ICE-breaker ping to use the new aliases #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 5, 2020

Conversation

LeSeulArtichaut
Copy link
Contributor

I'm not sure if this is really useful, but I think the "full" invocation is really long and not convenient to learn.

Related to rust-lang/rust#69949

@JohnTitor
Copy link
Member

I believe it's reasonable to tell that we have aliases for simplicity. We have some aliases and they might be changed/added so I think it's better to add a note and point to the triagebot.toml on rust-lang/rust.

@LeSeulArtichaut
Copy link
Contributor Author

LeSeulArtichaut commented Mar 25, 2020

@JohnTitor I wrote a note in 12b649d, but I'm not fully satisfied with the wording. Would you mind reviewing? Thanks 😄

@LeSeulArtichaut LeSeulArtichaut force-pushed the LeSeulArtichaut-breaker-ping branch from 6e11e5b to 12b649d Compare March 25, 2020 13:19
@pnkfelix
Copy link
Member

I think the thrust of @JohnTitor 's comment was that it would be best to provide the non-aliased versions first, since I suspect those will never change (it seems more likely we'd retire a given ICE-breaker group than rename it).

And then, after that, state that some aliases exist (with the link to the triagebot toml), that they are subject to change, and then give a second code block showing the invocations with the aliases.

Does that make sense?

@pnkfelix
Copy link
Member

(One reason it could be good to include the non-aliased versions in these docs is that if someone writes some tools, e.g. something to assist with triage, then it would be good for those tools to probably use the non-aliased versions...)

@JohnTitor
Copy link
Member

I think the thrust of @JohnTitor 's comment was that it would be best to provide the non-aliased versions first, since I suspect those will never change (it seems more likely we'd retire a given ICE-breaker group than rename it).

Yeah, that's exactly what I mean :)

@mark-i-m
Copy link
Member

mark-i-m commented Apr 3, 2020

Ping @LeSeulArtichaut :)

Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mark-i-m mark-i-m merged commit af75c10 into master Apr 5, 2020
@mark-i-m mark-i-m deleted the LeSeulArtichaut-breaker-ping branch April 5, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants