-
Notifications
You must be signed in to change notification settings - Fork 544
Change ICE-breaker ping to use the new aliases #631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I believe it's reasonable to tell that we have aliases for simplicity. We have some aliases and they might be changed/added so I think it's better to add a note and point to the triagebot.toml on rust-lang/rust. |
@JohnTitor I wrote a note in 12b649d, but I'm not fully satisfied with the wording. Would you mind reviewing? Thanks 😄 |
6e11e5b
to
12b649d
Compare
I think the thrust of @JohnTitor 's comment was that it would be best to provide the non-aliased versions first, since I suspect those will never change (it seems more likely we'd retire a given ICE-breaker group than rename it). And then, after that, state that some aliases exist (with the link to the triagebot toml), that they are subject to change, and then give a second code block showing the invocations with the aliases. Does that make sense? |
(One reason it could be good to include the non-aliased versions in these docs is that if someone writes some tools, e.g. something to assist with triage, then it would be good for those tools to probably use the non-aliased versions...) |
Yeah, that's exactly what I mean :) |
Ping @LeSeulArtichaut :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'm not sure if this is really useful, but I think the "full" invocation is really long and not convenient to learn.
Related to rust-lang/rust#69949