Skip to content

compiletest: specify which special env var and which particular CI job #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2024
Merged

compiletest: specify which special env var and which particular CI job #1960

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2eb9706
compiletest: specify which special env var and which particular CI job
jieyouxu Apr 8, 2024
94d7c70
compiletest: fix grammar and add link to Dockerfile
jieyouxu Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/tests/headers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,9 @@ The following header commands will check LLVM support:
Note: The test will fail on CI if the component does not exist.
* `needs-matching-clang` — ignores if the version of clang does not match the
LLVM version of rustc.
These tests are always ignored unless a special environment variable is set
(which is only done in one CI job).
These tests are always ignored unless a special environment variable
`RUSTBUILD_FORCE_CLANG_BASED_TESTS` is set
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
These tests are always ignored unless a special environment variable
`RUSTBUILD_FORCE_CLANG_BASED_TESTS` is set
These tests are always ignored unless a special environment variable,
`RUSTBUILD_FORCE_CLANG_BASED_TESTS`, is set

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added commas

(which is only done in one CI job `x86_64-gnu-debug`).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add link to this file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a link to the Dockerfile


See also [Debuginfo tests](compiletest.md#debuginfo-tests) for headers for
ignoring debuggers.
Expand Down