Skip to content

Update diagnostics to flat fluent message paths #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2022
Merged

Update diagnostics to flat fluent message paths #1489

merged 1 commit into from
Oct 25, 2022

Conversation

Noratrieb
Copy link
Member

As implemented in rust-lang/rust#103345

@Noratrieb
Copy link
Member Author

@davidtwco

@JohnTitor JohnTitor added S-blocked Status: this PR is blocked waiting for something S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content and removed S-blocked Status: this PR is blocked waiting for something labels Oct 22, 2022
@JohnTitor
Copy link
Member

This LGTM, @davidtwco could you review?

@davidtwco davidtwco merged commit 6686b1e into rust-lang:master Oct 25, 2022
@Noratrieb Noratrieb deleted the flat-diag branch October 25, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Noratrieb @JohnTitor @davidtwco