Add a feature flag for ASM #9991
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| else if path.segments.last().identifier == self.sess.ident_of("asm") { | ||
| // fixme: remove the false once the ASM feature has been |
There was a problem hiding this comment.
If you change this to // NOTE: remove if false after next snapshot (or something like that, the // NOTE part is the important bit), then make tidy will show it, so the person who makes the next snapshot will be alerted to remove it.
bors
added a commit
that referenced
this pull request
Oct 21, 2013
Fixes #9882 Note that the actual checking code is inside a if false in order to compile libstd properly. libstd uses asm! in rt. If we put ```#[feature(asm)]``` in libstd, it fails to build at stage0 beacause the asm feature is not known yet by the snapshot compiler. We must wait that this PR arrives into the snapshot in order to actually activate the checking code.
bors
added a commit
that referenced
this pull request
Oct 22, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 27, 2023
…gs, r=xFrednet Document lint configuration values in Clippy's book changelog: document lint configuration values in Clippy's book fixes rust-lang#9991 r? `@xFrednet`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9882
Note that the actual checking code is inside a if false in order to compile libstd properly.
libstd uses asm! in rt. If we put
#[feature(asm)]in libstd, it fails to build at stage0 beacause theasm feature is not known yet by the snapshot compiler.
We must wait that this PR arrives into the snapshot in order to actually activate the checking code.