Skip to content

Change default lint output format #9782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2013
Merged

Change default lint output format #9782

merged 1 commit into from
Oct 9, 2013

Conversation

geoffhill-zz
Copy link
Contributor

Since lint check attributes are the preferred way of selectively
enabling/disabling lint checks, the output format of a failed
default check has been changed to reflect that.

When lint checks are being explicitly set by a command-line flag
or an attribute, the behavior is unchanged, so that the user can
quickly pinpoint the source.

Supersedes the patch suggested in #9778
Closes #6580

Since lint check attributes are the preferred way of selectively
enabling/disabling lint checks, the output format of a failed
default check has been changed to reflect that.

When lint checks are being explicitly set by a command-line flag
or an attribute, the behavior is unchanged, so that the user can
quickly pinpoint the source.

Closes #6580
bors added a commit that referenced this pull request Oct 9, 2013
Since lint check attributes are the preferred way of selectively
enabling/disabling lint checks, the output format of a failed
default check has been changed to reflect that.

When lint checks are being explicitly set by a command-line flag
or an attribute, the behavior is unchanged, so that the user can
quickly pinpoint the source.

Supersedes the patch suggested in #9778
Closes #6580
@bors bors closed this Oct 9, 2013
@bors bors merged commit 9c84982 into rust-lang:master Oct 9, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Nov 21, 2022
Address issues 9739 and 9782

This PR fixes rust-lang#9739 in the manner I suggested in rust-lang/rust-clippy#9739 (comment).

This PR also fixes the compilation failures in rust-lang#9782 (but doesn't address `@e00E's` other objections).

Fixes rust-lang#9739

r? `@Jarcho`

changelog: Fix two `needless_borrow` false positives, one involving borrows in `if`-`else`s, the other involving qualified function calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lint hints should use attribute syntax, not command line syntax
3 participants