Skip to content

lint hints should use attribute syntax, not command line syntax #6580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue May 18, 2013 · 2 comments · Fixed by #9782
Closed

lint hints should use attribute syntax, not command line syntax #6580

brson opened this issue May 18, 2013 · 2 comments · Fixed by #9782
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented May 18, 2013

I see output like this: warning: unnecessaryunsafeblock [-W unused-unsafe (default)].

rustc is telling you the command line argument to control this warning, but command line arguments are not our preferred way of turning on warnings.
@catamorphism
Copy link
Contributor

(bug triage) Easy to fix; doesn't look like a nominatable one to me.

@metajack
Copy link
Contributor

triage bump

This was referenced Oct 9, 2013
Closed
Merged
bors added a commit that referenced this issue Oct 9, 2013
@bors
auto merge of #9782 : geoffhill/rust/lint-format2, r=alexcrichton
e505d4c 
Since lint check attributes are the preferred way of selectively
enabling/disabling lint checks, the output format of a failed
default check has been changed to reflect that.

When lint checks are being explicitly set by a command-line flag
or an attribute, the behavior is unchanged, so that the user can
quickly pinpoint the source.

Supersedes the patch suggested in #9778
Closes #6580
@bors bors closed this as completed in 9c84982 Oct 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change default lint output format
3 participants
@metajack @brson @catamorphism