Skip to content

Fix a small mistake in SliceIndex's documentation #97363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2022
Merged

Fix a small mistake in SliceIndex's documentation #97363

merged 1 commit into from
May 25, 2022

Conversation

wackbyte
Copy link
Contributor

Originally, it said "get_(mut_)unchecked," but the method's actual name is get_unchecked_mut.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 24, 2022
@rust-highfive
Copy link
Contributor

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 24, 2022
JohnTitor
JohnTitor approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@JohnTitor
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 24, 2022

📌 Commit ce94773 has been approved by JohnTitor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 24, 2022
@JohnTitor JohnTitor assigned JohnTitor and unassigned m-ou-se May 24, 2022
@JohnTitor JohnTitor mentioned this pull request May 24, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 24, 2022
@bors
Auto merge of rust-lang#97372 - JohnTitor:rollup-6owv1v0, r=JohnTitor
f80e454 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#93966 (document expectations for Waker::wake)
 - rust-lang#97266 (Make weird name lints trigger behind cfg_attr)
 - rust-lang#97355 (Remove unused brush image)
 - rust-lang#97358 (Update minifier-rs version to 0.1.0)
 - rust-lang#97363 (Fix a small mistake in `SliceIndex`'s documentation)
 - rust-lang#97364 (Fix weird indentation in continue_keyword docs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7ed7f65 into rust-lang:master May 25, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 25, 2022
@wackbyte wackbyte deleted the sliceindex-doc-typo branch May 25, 2022 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
6 participants
@wackbyte @rust-highfive @JohnTitor @bors @m-ou-se @rustbot