Fix duplicate directory separator in --remap-path-prefix. #96562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 3614bd3 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 29, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#96390 (Switch JS code to ES6 - part 2) - rust-lang#96527 (RustWrapper: explicitly don't handle DXILPointerTyID) - rust-lang#96536 (rustdoc: fix missing method list for primitive deref target) - rust-lang#96559 (Use the correct lifetime binder for elided lifetimes in path.) - rust-lang#96560 (Remove unnecessary environment variable in cf-protection documentation) - rust-lang#96562 (Fix duplicate directory separator in --remap-path-prefix.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler will currently emit duplicate directory separators when
--remap-path-prefixhas an exact match of the working directory and it is invoked with a relative path to the main source file. For examplerustc src/main.rs -Cdebuginfo=2 --remap-path-prefix="$(pwd)=abc"will produce the path
abc//src/main.rsin debuginfo. This is becausesome_path.join("")will append a directory separator tosome_pathand then LLVM does not check if the working directory already ends a directory separator before concatenating it with the relative path.