Recover most impl Trait and dyn Trait lifetime bound suggestions under NLL
#96385
+244
−148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
marmeladema
commented
Apr 25, 2022
| // i32, which is the type of y but with the anonymous region replaced | ||
| // with 'a, the corresponding bound region and is_first which is true if | ||
| // the hir::Param is the first parameter in the function declaration. | ||
| pub fn find_param_with_region<'tcx>( |
There was a problem hiding this comment.
This has just been split out from NiceRegionError::find_param_with_region as a free standing function.
|
Good job on this :) Did you bless with compare-mode=nll? (CI will catch it, but figured I would bring it up if you didn't and there's potentially anything that changes) @bors r+ |
|
📌 Commit e1b074a has been approved by |
bors
added
S-waiting-on-bors
Yep, I did it properly this time 👍 |
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 26, 2022
…bound-suggestions, r=jackh726 Recover most `impl Trait` and `dyn Trait` lifetime bound suggestions under NLL This is done by replacing the duplicated (and very partial) implementation from borrowck with one inspsired from `NiceRegionError::try_report_static_impl_trait` and by re-using `suggest_new_region_bound`. Fixes rust-lang#96277 r? `@jackh726`
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Apr 26, 2022
…bound-suggestions, r=jackh726 Recover most `impl Trait` and `dyn Trait` lifetime bound suggestions under NLL This is done by replacing the duplicated (and very partial) implementation from borrowck with one inspsired from `NiceRegionError::try_report_static_impl_trait` and by re-using `suggest_new_region_bound`. Fixes rust-lang#96277 r? ``@jackh726``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#92569 (Improve Error Messaging for Unconstructed Structs and Enum Variants in Generic Contexts) - rust-lang#96370 (Cleanup `report_method_error` a bit) - rust-lang#96383 (Fix erased region escaping into wfcheck due to rust-lang#95395) - rust-lang#96385 (Recover most `impl Trait` and `dyn Trait` lifetime bound suggestions under NLL) - rust-lang#96410 (rustdoc: do not write `{{root}}` in `pub use ::foo` docs) - rust-lang#96430 (Fix handling of `!` in rustdoc search) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 28, 2022
…-lifetime-suggestion, r=jackh726 Recover suggestions to introduce named lifetime under NLL Fixes rust-lang#96157 r? `@jackh726` Built on top of rust-lang#96385 so only the second commit is relevant
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 28, 2022
…-lifetime-suggestion, r=jackh726 Recover suggestions to introduce named lifetime under NLL Fixes rust-lang#96157 r? ``@jackh726`` Built on top of rust-lang#96385 so only the second commit is relevant
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 28, 2022
…-lifetime-suggestion, r=jackh726 Recover suggestions to introduce named lifetime under NLL Fixes rust-lang#96157 r? ```@jackh726``` Built on top of rust-lang#96385 so only the second commit is relevant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by replacing the duplicated (and very partial) implementation from borrowck with one inspsired from
NiceRegionError::try_report_static_impl_traitand by re-usingsuggest_new_region_bound.Fixes #96277
r? @jackh726