Correct safety reasoning in str::make_ascii_{lower,upper}case()
#95753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @dtolnay (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit b399e7e has been approved by |
bors
added
S-waiting-on-bors
dtolnay
added
the
T-libs
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 7, 2022
Rollup of 4 pull requests Successful merges: - rust-lang#95189 (Stop flagging unexpected inner attributes as outer ones in certain diagnostics) - rust-lang#95752 (Regression test for rust-lang#82866) - rust-lang#95753 (Correct safety reasoning in `str::make_ascii_{lower,upper}case()`) - rust-lang#95757 (Use gender neutral terms) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't understand why the previous comment was used (it was inserted in #66564), but it doesn't explain why these functions are safe, only why
str::as_bytes{_mut}()are safe.If someone thinks they make perfect sense, I'm fine with closing this PR.